-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick main back to development #2535
Conversation
I might add my signature to the cherry-picked commits if this is required by the procedure (DCO), but I thought it would be okay to keep it as is. Please let me know. |
Note, for reference purposes Jan is picking this back up and updating it to include merges since this PR was submitted. I'll then be reviewing and testing it so we can get it merged asap. |
Signed-off-by: chanmosq <75444793+chanmosq@users.noreply.github.com>
* Add the offline installer instructions for Windows Signed-off-by: Mike Chang <changml@amazon.com>
Update system requirements link and clarify snap instructions Signed-off-by: Mike Chang <changml@amazon.com>
* Update code-of-conduct.md Removed mentions of CNCF Signed-off-by: Naomi Washington <70667788+Naomi-Wash@users.noreply.github.com> * Update code-of-conduct.md Removed now extraneous line regarding other languages. Signed-off-by: Roddie Kieley <rkieley@redhat.com> --------- Signed-off-by: Naomi Washington <70667788+Naomi-Wash@users.noreply.github.com> Signed-off-by: Roddie Kieley <rkieley@redhat.com> Co-authored-by: Roddie Kieley <rkieley@redhat.com>
8d899ef
to
751070a
Compare
I push-forced the code with the updates, please see the updated description in the first post. |
👍🏼 @RoddieKieley Looks good to me. Just need you to hit the approve button and do the merge. |
@RoddieKieley could you take a look at this? |
Stabilization/2310 Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Added 23.10 release notes. Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
prefab override clarifications and updates Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Stabilization/23101 -> main for publishing Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
* Updating project export instructions to warn O3DE installer/SDK users. Installed versions of O3DE must use profile configuration and non-monolithic builds in order to package their game Signed-off-by: AMZN-Gene <genewalt@amazon.com> * Minor. Whitespace fix Signed-off-by: AMZN-Gene <genewalt@amazon.com> --------- Signed-off-by: AMZN-Gene <genewalt@amazon.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
…elease (#2519) * initial documentation updates for recent exporter changes for point release Signed-off-by: TJ Kotha <tankotha@amazon.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Gene Walters <32776221+AMZN-Gene@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * addressed feedback Signed-off-by: TJ Kotha <tankotha@amazon.com> * removed unnecessary warning for profile builds Signed-off-by: TJ Kotha <tankotha@amazon.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Gene Walters <32776221+AMZN-Gene@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * Update content/docs/user-guide/packaging/project-export/project-export-cli.md Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> * adding wildcard documentation for seed parameters Signed-off-by: TJ Kotha <tankotha@amazon.com> * splitting argument table into separate unique entries Signed-off-by: TJ Kotha <tankotha@amazon.com> * minor sentence improvement Signed-off-by: TJ Kotha <tankotha@amazon.com> * minor sentence improvements Signed-off-by: TJ Kotha <tankotha@amazon.com> * split up snippets into smaller sections Signed-off-by: TJ Kotha <tankotha@amazon.com> --------- Signed-off-by: TJ Kotha <tankotha@amazon.com> Signed-off-by: T.J. Kotha <112996779+tkothadev@users.noreply.github.com> Co-authored-by: TJ Kotha <tankotha@amazon.com> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Co-authored-by: Gene Walters <32776221+AMZN-Gene@users.noreply.github.com>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Roddie Kieley <rkieley@redhat.com>
Signed-off-by: kursad-k <67970138+kursad-k@users.noreply.github.com>
Signed-off-by: Roddie Kieley <rkieley@redhat.com>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
* adding documentation for the new export button Signed-off-by: TJ Kotha <tankotha@amazon.com> * addressing feedback round 1 Signed-off-by: TJ Kotha <tankotha@amazon.com> * updating screenshots Signed-off-by: TJ Kotha <tankotha@amazon.com> --------- Signed-off-by: TJ Kotha <tankotha@amazon.com> Co-authored-by: TJ Kotha <tankotha@amazon.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
2141b4f
to
83b6eb7
Compare
I force-pushed the PR again to fix DCO: I signed all commits. |
@ShaunaGordon could you please give an approve to this PR? |
@jhanca-robotecai Done. Looks good. 👍🏼 |
Change summary
This PR cherry-picks changes that were pushed to the
main
branch (directly or via stabilization branches) and that were not pushed to thedevelopment
branch causing the misalignment.In December I synchronized the branches by doing the following cherry-picks:
aaa7c60
f5dad19
133b8f2
d9d3a03
b816fd7
05fa6a3
da33e38
b7fe90c
14dea04
Unfortunately, the code was not reviewed and not merged. Today (July 4) I picked up the task again and created a supportive branch on which I created the linear history for cherry-picking for all commits that entered
main
branch after the synchronization that took place earlier. The branch is pushed to this repo for the reviewer's convenience:jhanca-robotecai/main_linear23101
. Note, that there is no difference between theHEAD
ofjhanca-robotecai/main_linear23101
and theHEAD
ofmain
. Thanks to the linear history, I was able to cherry-pick the code on top of this branch. I.e. I was able to cherry-pick all commits from the main branch between b7fe90c and 31622c5Testing
I pushed one more branch for the reviewer's convenience:
jhanca-robotecai/main_development
. I cherry-picked to this branch all commits that entered thedevelopment
branch after the lastmain
updates. When comparingjhanca-robotecai/main_development
withjhanca-robotecai/merge_main
there are several differences, caused by the fact that was merged intodevelopment
and never made intomain
:This proves I did not miss any changes in
main
branch.Concerns
I am aware it is impossible to review this PR due to the size of the change. This is caused by the cherry-pick of #2475 which is equally big. I did not change those files myself, but AFAIK those are autogenerated files that should be updated again. I might revert those changes to make this PR easier to review. Just let me know. Otherwise, feel free to push the code to my branch or open PR to my branch. Thanks for help!