Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Mode bug - deleting chars not dedenting subsequent lines #37

Open
shaunlebron opened this issue Aug 17, 2018 · 5 comments
Open

Smart Mode bug - deleting chars not dedenting subsequent lines #37

shaunlebron opened this issue Aug 17, 2018 · 5 comments

Comments

@shaunlebron
Copy link
Collaborator

vscode-bug-dedent

@oakmac
Copy link
Owner

oakmac commented Aug 17, 2018

I do not see this behavior on the master branch right now:

issue-37

Thoughts?

@PEZ
Copy link

PEZ commented Aug 18, 2018

For me it sometimes works, and sometimes not. I can't figure out a pattern to it, though.

@PEZ
Copy link

PEZ commented Aug 18, 2018

Actually, for me it happens also when adding characters. Like so:

parinf-indent-subsequent-lines

And sometimes when deleting, like so:
parinf-indent-subsequent-lines2

@PEZ
Copy link

PEZ commented Aug 18, 2018

I'm wondering if this could be a performance issue. My Mac is pretty slow. I have a similar issue with Calva Format with its onType and onSave formatting providers. Sometimes it just doesn't happen, even though I can debug log it and see that I did ”ask” vscode to do it. Maybe vscode skips bothering with edits if it takes too long time from the event handler is triggered to the edits are computed?

@oakmac
Copy link
Owner

oakmac commented Aug 18, 2018

@PEZ Thank you for looking into this!

Maybe vscode skips bothering with edits if it takes too long time from the event handler is triggered to the edits are computed?

I suspect you are onto something here: a timing issue with respect to Edits / user input. Will need to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants