Fix false positive non-utf symlinks reported

[fernflower]

Because of botched up check for python2 valid utf symlinks were reported as non-utf ones.

OAMG-8629

Relates on oamg/leapp#821

[github-actions]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

• review please to notify leapp developers of review request
• /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

• /rerun to schedule basic regression tests using this pr build and leapp*master* as artifacts
• /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
• /rerun-sst to schedule sst tests using this pr build and leapp*master* as artifacts
• /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

[fernflower]

/rerun

[github-actions]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5614910

[github-actions]

Testing Farm request for RHEL-8.6-rhui/5614910 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-rhui/5614910 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.6.0-Nightly/5614910 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.8.0-Nightly/5614910 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5614910 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[pirat89]

@fernflower As the previous tests has not caught the problem before, is the particular test that discovered the issue now part of the executed integration tests for the PR? If so, do you know the name? Just tried to search for "root" i could not find anything related. From my understanding, such a test exists, so if it's not executed now, possibly it could be added to the set? Otherwise it would be nice to prepare unit-test so it's covered. But missing tests is not blocker from my POV for the merge right now. Can be tested manually still. The fix seems reasonable to me, haven't tested it yet.

[fernflower]

@pirat89 Yeah, there is a test, it's MR199 to the integration tests in gitlab. We just decided not to merge the MR before the leapp change gets in not to cause extra failures.

[fernflower]

/rerun

[github-actions]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5637134

[github-actions]

Testing Farm request for RHEL-8.6-rhui/5637134 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-rhui/5637134 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.6.0-Nightly/5637134 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.8.0-Nightly/5637134 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5637134 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5637134 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[fernflower]

/packit build

[pirat89]

the current implementation leads to traceback on rhel8:

# mkdir /root/břeťa
# ln -s /root/břeťa/ /bobošík
# leapp preupgrade --debug
...
2023-03-23 13:27:17.925 INFO     PID: 26891 leapp.workflow: Workflow finished due to the until-phase flag
2023-03-23 13:27:17.932 INFO     PID: 26891 leapp: Answerfile will be created at /var/log/leapp/answerfile
Traceback (most recent call last):
  File "/usr/bin/leapp", line 9, in <module>
    load_entry_point('leapp==0.15.1', 'console_scripts', 'leapp')()
  File "/usr/lib/python2.7/site-packages/leapp/cli/__init__.py", line 45, in main
    cli.command.execute('leapp version {}'.format(VERSION))
  File "/usr/lib/python2.7/site-packages/leapp/utils/clicmd.py", line 111, in execute
    args.func(args)
  File "/usr/lib/python2.7/site-packages/leapp/utils/clicmd.py", line 133, in called
    self.target(args)
  File "/usr/lib/python2.7/site-packages/leapp/cli/commands/upgrade/breadcrumbs.py", line 163, in wrapper
    return f(*args, breadcrumbs=breadcrumbs, **kwargs)
  File "/usr/lib/python2.7/site-packages/leapp/cli/commands/preupgrade/__init__.py", line 78, in preupgrade
    util.generate_report_files(context, report_schema)
  File "/usr/lib/python2.7/site-packages/leapp/cli/commands/upgrade/util.py", line 148, in generate_report_files
    generate_report_file(messages, context, report_txt, report_schema)
  File "/usr/lib/python2.7/site-packages/leapp/utils/report.py", line 121, in generate_report_file
    f.write('Remediation: {}\n'.format(remediation))
  File "/usr/lib/python2.7/site-packages/leapp/reporting/__init__.py", line 283, in __repr__
    return "\n".join([repr(r) for r in self._remediations])
  File "/usr/lib/python2.7/site-packages/leapp/reporting/__init__.py", line 248, in __repr__
    return "[{}] {}".format(self._value['type'], ' '.join(self._value['context']))
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0159' in position 20: ordinal not in range(128)

[github-actions]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5782399

[github-actions]

Testing Farm request for RHEL-7.9-rhui/5782399 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.6-rhui/5782399 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.8.0-Nightly/5782399 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.6.0-Nightly/5782399 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5782399 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5782399 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[fernflower]

/packit build

[fernflower]

/packit test

[fernflower]

/rerun 821

[github-actions]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5830593

[github-actions]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5830974

[github-actions]

Testing Farm request for RHEL-8.6-rhui/5830974;5830593 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-rhui/5830974;5830593 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.8.0-Nightly/5830974;5830593 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-8.6.0-Nightly/5830974;5830593 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5830974;5830593 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[github-actions]

Testing Farm request for RHEL-7.9-ZStream/5830974;5830593 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

[fernflower]

/packit test oamg/leapp#821

[pirat89]

The fix in framework has been merged in upstream. Manually tested, seems it works as it should. Merging \o/

Note: the failed tests seems to be unrelated to this fix. Checking the failures, it seems as issue in tests.