Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify recursion depth for branches #625

Closed
tschmidtb51 opened this issue May 23, 2023 · 3 comments · Fixed by #806
Closed

Specify recursion depth for branches #625

tschmidtb51 opened this issue May 23, 2023 · 3 comments · Fixed by #806
Assignees
@tschmidtb51
Labels
csaf 2.0 csaf 2.0 work csaf 2.1 csaf 2.1 work editor-revision already worked on in the editor revision

Comments

@tschmidtb51
Copy link
Contributor

I remember that we discussed a recursion depth of 25 nested branches within a /product_tree. However, I didn't see it in the standard (or I overlooked it).
I think that might be a valuable addition to the guidance - especially for a future API.
@tschmidtb51 tschmidtb51 added the csaf 2.1 csaf 2.1 work label May 23, 2023
@tschmidtb51 tschmidtb51 self-assigned this May 23, 2023
@tschmidtb51
Copy link
Contributor Author

tschmidtb51 commented Feb 24, 2024 •
edited
Loading

The TC should decide whether this should be a formal (section 5) or informal requirement (Appendix C) as well as whether it is a "SHOULD" or a "MUST" requirement.

@tschmidtb51
Copy link
Contributor Author

tschmidtb51 commented Feb 24, 2024 •
edited
Loading

Checklist:

  • add text to appropriate place

  • add test files

    • valid
    • invalid

  • Add to guidance for CSAF 2.0

@tschmidtb51
Copy link
Contributor Author

As we have currently 13 branch categories, I suggest 30 as limit and the following wording in the formal part:

5.4 Branch recursion

The /product_tree uses a nested structure for branches. Along a single path to a leaf, the recursion of branches is limited to 30 repetitions. Therefore, the longest path to a leaf is:

/product_tree/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/branches[]/product

@tschmidtb51 tschmidtb51 changed the title Appendix C: State recursion depth Specify recursion depth for branches Apr 24, 2024
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue May 29, 2024
@tschmidtb51
Branches recursion depth
058b6a5 
- addresses parts of oasis-tcs#625
- add section about recursion depth
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue May 29, 2024
@tschmidtb51
Branches recursion depth
c3ad46a 
- addresses parts of oasis-tcs#625
- add mandatory test 6.1.34 to check branches recursion depth
- add invalid examples for 6.1.34
- add valid example for 6.1.34
- update testdata schema to accept new test
@tschmidtb51 tschmidtb51 mentioned this issue May 29, 2024
Merged
@tschmidtb51 tschmidtb51 added editor-revision already worked on in the editor revision csaf 2.0 csaf 2.0 work and removed tc-discussion-needed labels May 29, 2024
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue Oct 24, 2024
@tschmidtb51
Branches recursion depth
454f574 
- fixes oasis-tcs#625
- add original recursion depth of 25 to Guidance of CSAF 2.0
@tschmidtb51 tschmidtb51 mentioned this issue Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tschmidtb51 tschmidtb51

Labels
csaf 2.0 csaf 2.0 work csaf 2.1 csaf 2.1 work editor-revision already worked on in the editor revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Branches recursion depth tschmidtb51/csaf
1 participant
@tschmidtb51