CPE #324
CPE #324
Conversation
tschmidtb51
commented
Jul 24, 2021
tschmidtb51
commented
- resolves CPE regex #91
- add test for CPE regex against dictionary
- resolves oasis-tcs#91 - add manual test for CPE regex against official dictionaries
- addresses parts of oasis-tcs#91 and oasis-tcs#38 - add new workflow for CPE test
- addresses parts of oasis-tcs#91 and oasis-tcs#38 - add newline at EOF
- addresses parts of oasis-tcs#91 and oasis-tcs#38 - clarify steps by providing names
I met with spellcheck and she likes this version more. Maybe some intrinsic expansions were secretly needed to make the script work ... then I am happy to revert / adapt.
| @@ -0,0 +1,61 @@ | |||
| #!/bin/bash | |||
|
|
|||
There was a problem hiding this comment.
In my own daily work, I tend to have a `# synopsis like sigle line comment always on line 2 ... should we do this here too?
There was a problem hiding this comment.
Feel free to do so.
| @@ -2,3 +2,5 @@ | |||
| meeting_minutes/.DS_Store | |||
| .DS_Store | |||
| *_strict_schema.json | |||
| official-cpe-dictionary_v2.3.* | |||
There was a problem hiding this comment.
I can imagine a single official-cpe-dictionary_v2* would do but I am +0 on just keeping your version - after all it is only a git ignore file.
There was a problem hiding this comment.
I tend to be a bit more specific in .gitignore as it helps me to avoid the "works on my machine". But I'm happy with both variants... So that's up to you.
Do not know if this is practical and this should also work. ... what could possibly go wrong, right?
There was a problem hiding this comment.
I changed the driver and the validator without testing and hope the testing happens within this PR mechanics ... hope helps 😁 - it worked (I usually do not change that much as reviewer ... esp. without prior verification).
Note: I have no problem when my commits are reverted (I approve the PR never the less).
Let us merge this fast, it is a very good contribution I think. Thank you so much @tschmidtb51 !
|
Let the tests start 😜 I will merge now. |
