Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid signatures #724

Merged
merged 4 commits into from
May 12, 2024
Merged

Valid signatures #724

merged 4 commits into from
May 12, 2024

Conversation

tschmidtb51
Copy link
Contributor

- addresses parts of oasis-tcs#678
- add FAQ on signing
- addresses parts of oasis-tcs#678
- provide tool guidance
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when replacing check with verification.

csaf_2.0/guidance/faq.md Outdated Show resolved Hide resolved
csaf_2.0/guidance/faq.md Outdated Show resolved Hide resolved
tschmidtb51 and others added 2 commits April 24, 2024 18:01
- addresses feedback of oasis-tcs#724
- improve wording for readability

Co-authored-by: Omar Santos <os@cisco.com>
- addresses feedback of oasis-tcs#724
- change "check" to "verification"

Co-authored-by: Stefan Hagen <stefan@hagen.link>
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@santosomar
Copy link
Contributor

A motion will be put in place to approve the contribution as stated after today's TC meeting.

@tschmidtb51 tschmidtb51 marked this pull request as ready for review April 24, 2024 17:22
@tschmidtb51 tschmidtb51 added motion This item has a motion pending and removed tc-discussion-needed labels Apr 24, 2024
@santosomar
Copy link
Contributor

This motion has automatically passed on 2024-05-01 23:00 UTC.

https://groups.oasis-open.org/discussion/motion-for-724

@santosomar santosomar merged commit e228c9d into oasis-tcs:master May 12, 2024
5 checks passed
@tschmidtb51 tschmidtb51 removed the motion This item has a motion pending label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csaf 2.0 csaf 2.0 work FAQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants