Optional Test: Same Timestamps in Revision History #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tschmidtb51
commented
May 27, 2024
tschmidtb51
commented
- resolves Add test: same timestamps in revision history #627
- add optional test that warns if two timestamps in the revision history are the same
- add invalid examples for 6.2.21
- add valid examples for 6.2.21
- update testcase and schema for testcases
- resolves oasis-tcs#627 - add optional test that warns if two timestamps in the revision history are the same - add invalid examples for 6.2.21 - add valid examples for 6.2.21 - update testcase and schema for testcases
- addresses parts of oasis-tcs#744 - correct metadata of valid example 3 of 6.2.21 - unify metadata of invalid example 3 of 6.2.21 - fix invalid JSON
sthagen
reviewed
May 28, 2024
sthagen
approved these changes
May 28, 2024
tschmidtb51
added
tc-discussion-needed
call_to_action
santosomar
requested changes
May 29, 2024
There was a problem hiding this comment.
How about the following text in order to make it easier to understand and grammatically correct:
"When converted to UTC, the timestamps of all items in the revision history MUST be tested to ensure that are unique and do not overlap (i.e., pairwise disjoint)."
- addresses review comment from oasis-tcs#744 - state clearly that conversion needs to happen first
|
@sthagen, @santosomar: I added a sentence for implementers regarding the UTC conversion. I think that should resolve the discussion. |
- addresses parts of oasis-tcs#627 - add invalid examples for 6.2.21
- addresses review comment from oasis-tcs#744 - simplify requirement on comparison
tschmidtb51
added
motion
|
The motion to accept the pull request as suggested in #744 and include it into CSAF 2.1, has passed. It automatically carried on 2024-06-07 23:00 UTC. https://groups.oasis-open.org/discussion/motion-for-744 |
santosomar
approved these changes
Jun 11, 2024
tschmidtb51
added
motion_passed
…to same-timestamps
tschmidtb51
merged commit 1f005f2
into
oasis-tcs:editor-revision-2024-05-29
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.