feat(cmd/rofl): Implement deploy via ROFL market #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
kostko
force-pushed
the
kostko/feature/rofl-market
branch
from
3c9309c to
4594a95
Compare
kostko
force-pushed
the
kostko/feature/rofl-market
branch
3 times, most recently
from
f793ffc to
6a90176
Compare
kostko
force-pushed
the
kostko/feature/rofl-market
branch
5 times, most recently
from
131076c to
35b5af8
Compare
kostko
force-pushed
the
kostko/feature/rofl-market
branch
from
35b5af8 to
7300a6d
Compare
matevz
reviewed
Apr 15, 2025
kostko
force-pushed
the
kostko/feature/rofl-market
branch
5 times, most recently
from
f757357 to
e877ee8
Compare
matevz
approved these changes
Apr 17, 2025
Comment on lines
+13
to
+15
| TermHour = "hour" | ||
| TermMonth = "month" | ||
| TermYear = "year" |
There was a problem hiding this comment.
Suggested change
| TermHour = "hour" | |
| TermMonth = "month" | |
| TermYear = "year" | |
| TermHour = "hourly" | |
| TermMonth = "monthly" | |
| TermYear = "yearly" |
There was a problem hiding this comment.
This has already been renamed for the provider configuration, but I'm less sure about the --term option? E.g. in top-up you would say top-up --term month --term-count 1 to specify 1 month.
kostko
force-pushed
the
kostko/feature/rofl-market
branch
from
e877ee8 to
59652bb
Compare
kostko
force-pushed
the
kostko/feature/rofl-market
branch
from
59652bb to
15b9e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.