Skip to content

cmd/rofl/machine: Rename terminate/cancel -> stop/remove #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

matevz
Copy link
Member

@matevz matevz commented Apr 28, 2025

This PR renames:

  1. oasis rofl machine terminate -> oasis rofl machine stop
  2. oasis rofl machine cancel -> oasis rofl machine remove

It keeps old "terminate" and "cancel" subcommands as aliases.

Rationale

  1. The "terminate" term may also associate with "terminate your subscription", which is not the case. The "stop" term is also more consistent with Docker's "start/stop/restart" terminology and also with oasis rofl machine restart.
  2. The "cancel" term may be a bit too soft since it cancels your subscription and destroys the machine. I'd prefer to call this "remove" for consistency with other "add/remove" subcommands.

Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit a13041b
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/680f84f34910fb0008a94446

@matevz matevz force-pushed the matevz/feature/rofl-machine-renamings branch from 81ca1f6 to a13041b Compare April 28, 2025 13:38
@matevz matevz merged commit d75f12c into master Apr 28, 2025
4 checks passed
@matevz matevz deleted the matevz/feature/rofl-machine-renamings branch April 28, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants