Skip to content

ROFL app instance transactions tab #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025
Merged

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Apr 4, 2025

Extracted from #1777

Based on new designs current tx list is moved to "Updates" tab. In transactions tab we gonna show instance transactions list.

Copy link

github-actions bot commented Apr 4, 2025

Deployed to Cloudflare Pages

Latest commit: 0d222b8f0eecac3d5f37d12f070022c3e7d36b50
Status:✅ Deploy successful!
Preview URL: https://93b0e252.oasis-explorer.pages.dev
Alias: https://pr-1863.oasis-explorer.pages.dev

@buberdds buberdds force-pushed the mz/roflInstanceTransactions branch from 702444f to 0d222b8 Compare April 4, 2025 14:13
@buberdds buberdds marked this pull request as ready for review April 4, 2025 14:18
@buberdds buberdds self-assigned this Apr 4, 2025
@buberdds buberdds mentioned this pull request Apr 4, 2025
@lubej
Copy link
Contributor

lubej commented Apr 7, 2025

I am not completely sure if this PR introduces this issue, but on this ROFL App for example https://pr-1863.oasis-explorer.pages.dev/testnet/sapphire/rofl/app/rofl1qp55evqls4qg6cjw5fnlv4al9ptc0fsakvxvd9uw the pagination on transactions tab seems of.

@buberdds
Copy link
Contributor Author

buberdds commented Apr 7, 2025

yes there are a few issues with a new endpoint in Nexus. Hopefully this will be covered by oasisprotocol/nexus#959

@buberdds buberdds merged commit b623eb6 into master Apr 7, 2025
8 checks passed
@buberdds buberdds deleted the mz/roflInstanceTransactions branch April 7, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants