Fix RoundedBalance prop combinations #1902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
buberdds
reviewed
Apr 25, 2025
| @@ -91,4 +93,45 @@ describe('RoundedBalance', () => { | |||
| expect(screen.getByText('99,999.00000…')).toBeInTheDocument() | |||
| }) | |||
| }) | |||
|
|
|||
| for (const compactLargeNumbers of [false, true]) { | |||
There was a problem hiding this comment.
Every possible combination of params creates tons of useless snapshots. Can we define some test cases instead?
describe('should match snapshot for key configurations', () => {
const testCases = [
// common
{ value: '0.002231', ticker: 'ROSE' },
// compactLargeNumbers
{ value: '15000000', compactLargeNumbers: true },
{ value: '15000000', compactLargeNumbers: false },
// showSign
{ value: '5', showSign: true },
{ value: '-0.0047956', showSign: true },
// link
{
value: '5',
ticker: 'wROSE',
tickerAsLink: true,
tokenAddress: '0x8Bc2B030b299964eEfb5e1e0b36991352E56D2D3',
},
// Very small value
{ value: '0.00000000000002231' },
// Very large value
{ value: '1111111111111111111111111111111111111111111111111111' },
// Additional combos / whatever
{ value: '15000000', compactLargeNumbers: true, showSign: true, ticker: 'wROSE' },
{ value: '0.002231', tickerAsLink: true, tokenAddress: '0x8Bc2B030b299964eEfb5e1e0b36991352E56D2D3' },
]
testCases.forEach(params => {
it(`should match snapshot ${util.inspect(params)}`, () => {
...
})
})
})
There was a problem hiding this comment.
We should also have more normal tests above but I also want to have all the snapshots because it is not implemented in a composable way
buberdds
approved these changes
May 5, 2025
lukaw3d
force-pushed
the
lw/rounded-balance-params
branch
from
f42b3a4 to
b736f16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.