Show first 10 ERC-20 transfers on Transaction details page #1939
Conversation
kaja-osojnik
requested review from
lukaw3d,
buberdds,
csillag and
lubej
as code owners
Deployed to Cloudflare Pages
|
kaja-osojnik
force-pushed
the
kaja/ERC-20-transfer-list
branch
2 times, most recently
from
08ecce4 to
a888d53
Compare
|
@lukaw3d and @kaja-osojnik looks great, thanks for this! One thought I had was if it would it be clearer to rename this row from "Transaction Action" to "Recent transactions"? |
kaja-osojnik
force-pushed
the
kaja/ERC-20-transfer-list
branch
2 times, most recently
from
33d1af1 to
3142342
Compare
src/locales/en/translation.json
Outdated
| @@ -141,6 +143,7 @@ | |||
| "tokenInstance": "TokenID [<InstanceLink />] <TickerLink/>", | |||
| "tokens": "Tokens", | |||
| "totalVotes": "Total votes", | |||
| "recentTransactions": "Recent transactions", | |||
There was a problem hiding this comment.
One thought I had was if it would it be clearer to rename this row from "Transaction Action" to "Recent transactions"?
@donouwens these aren't transactions; the whole page is one transaction. Elsewhere we named this subset of events "Transfers". If we intend to show more than just transfers here then we need some other word 🤷
And I think "Recent" is misleading too
kaja-osojnik
force-pushed
the
kaja/ERC-20-transfer-list
branch
2 times, most recently
from
bbbe3ec to
5fca772
Compare
| <> | ||
| <Link | ||
| component={RouterLink} | ||
| to={`${location.pathname}#${transactionEventsContainerId}`} |
There was a problem hiding this comment.
I'll convert this to an absolute path, not based on current path. In search results this would incorrectly link to /mainnet/sapphire/search#transactionEvents
https://pr-1939.oasis-explorer.pages.dev/testnet/sapphire/search?q=0x9ce91f01d822bb4144de04ad4fce4711eb005c7d2824bfe38f670bf2916727ca
lukaw3d
force-pushed
the
kaja/ERC-20-transfer-list
branch
from
57f8195 to
6ef22db
Compare
lukaw3d
force-pushed
the
kaja/ERC-20-transfer-list
branch
from
5d04d83 to
6592705
Compare
lukaw3d
force-pushed
the
kaja/ERC-20-transfer-list
branch
from
6592705 to
d7f629b
Compare
Implementing: #1731
https://pr-1939.oasis-explorer.pages.dev/mainnet/sapphire/tx/0xc0c9511c5233447830d1769876d3fa16b4f6a64c89309e775ad1c3cb5e96992c
https://pr-1939.oasis-explorer.pages.dev/mainnet/sapphire/tx/0x9ce91f01d822bb4144de04ad4fce4711eb005c7d2824bfe38f670bf2916727ca
Before:
After:
