Skip to content

Make token icons larger #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Make token icons larger #1945

merged 2 commits into from
May 6, 2025

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 5, 2025

Part of #1769

image

@lukaw3d lukaw3d requested review from buberdds, csillag and lubej as code owners May 5, 2025 23:06
Copy link

github-actions bot commented May 5, 2025

Deployed to Cloudflare Pages

Latest commit: 47989bcb023716e4bff1c9be1dd8d5dffae08b6b
Status:✅ Deploy successful!
Preview URL: https://8a00bff0.oasis-explorer.pages.dev
Alias: https://pr-1945.oasis-explorer.pages.dev

@@ -12,9 +12,9 @@ function extractTwoChars(strRaw: string) {
return first + second
}

export const InitialsAvatar = ({ name, size }: { name: string; size: number }) => {
export const InitialsAvatar = ({ name, width, height }: { name: string; width: number, height: number }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace , with ;

) : (
<InitialsAvatar name={metadata?.name || name || address.slice(2, 4)} size={28} />
<InitialsAvatar name={metadata?.name || name || address.slice(2, 4)} width={40} height={28} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't size of a token icon be the same as "avatar icon"? Currently avatars are smaller

@lukaw3d lukaw3d force-pushed the lw/larger-token-icons branch from 0e0ffc8 to d59b68e Compare May 6, 2025 12:49
@lukaw3d lukaw3d merged commit 8905551 into master May 6, 2025
8 of 9 checks passed
@lukaw3d lukaw3d deleted the lw/larger-token-icons branch May 6, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants