-
Notifications
You must be signed in to change notification settings - Fork 10
Show address of Node ID #1962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show address of Node ID #1962
Conversation
Deployed to Cloudflare Pages
|
77a5360
to
d82f39d
Compare
Thanks! ![]() Let's make it a link and point to the account page, since most of the time, these accounts will have transactions, like: https://pr-1962.oasis-explorer.pages.dev/mainnet/consensus/address/oasis1qq5c20yqk5cfey43m49h8slqrmm42zd9qg352f53 (I know I said otherwise before :) ) RelatedFor validator nodes, like https://pr-1962.oasis-explorer.pages.dev/mainnet/consensus/address/oasis1qq5c20yqk5cfey43m49h8slqrmm42zd9qg352f53 would it make sense to somehow show "this account is a validator node" and have a link back to the validator page? Not sure if Nexus currently exposes the needed info for this anywhere? |
d82760d
to
5f676a4
Compare
<dt>{t('common.nodeAddress')}</dt> | ||
<dd> | ||
<AccountLink | ||
alwaysTrimOnTablet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alwaysTrimOnTablet
can be removed when highlighting is fixed
Links rendered instead of lables. The second part will be moved to another PR once Nexus support filtering validators by node_addr |
) | ||
} | ||
case NodeDisplayType.Id: | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would check that type is exhausted
Closes #1955
Node id/addr table
https://pr-1962.oasis-explorer.pages.dev/mainnet/sapphire/rofl/app/rofl1qpdzzm4h73gtes04xjn4whan84s3k33l5gx787l2/instances#instances
Replica details - Endorsing node address
https://pr-1962.oasis-explorer.pages.dev/mainnet/sapphire/rofl/app/rofl1qpdzzm4h73gtes04xjn4whan84s3k33l5gx787l2/instance/SbxH%2FftZHJ29t9xhiPfz6j3Fq%2Byw6E%2F1EqkWZac%2FH7U%3D
Validator details - Node address
https://pr-1962.oasis-explorer.pages.dev/mainnet/consensus/validators/oasis1qqtmpsavs44vz8868p008uwjulfq03pcjswslutz