Skip to content

Show address of Node ID #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 20, 2025
Merged

Show address of Node ID #1962

merged 7 commits into from
May 20, 2025

Conversation

Copy link

github-actions bot commented May 16, 2025

Deployed to Cloudflare Pages

Latest commit: 0418d4da49f5bbb3601e0a734e5f0065ebac8b4c
Status:✅ Deploy successful!
Preview URL: https://ef544820.oasis-explorer.pages.dev
Alias: https://pr-1962.oasis-explorer.pages.dev

@buberdds buberdds force-pushed the mz/nodeAddr branch 3 times, most recently from 77a5360 to d82f39d Compare May 16, 2025 13:42
@ptrus
Copy link
Member

ptrus commented May 16, 2025

Thanks!

Screenshot 2025-05-16 at 16 12 14

Let's make it a link and point to the account page, since most of the time, these accounts will have transactions, like: https://pr-1962.oasis-explorer.pages.dev/mainnet/consensus/address/oasis1qq5c20yqk5cfey43m49h8slqrmm42zd9qg352f53

(I know I said otherwise before :) )

Related

For validator nodes, like https://pr-1962.oasis-explorer.pages.dev/mainnet/consensus/address/oasis1qq5c20yqk5cfey43m49h8slqrmm42zd9qg352f53 would it make sense to somehow show "this account is a validator node" and have a link back to the validator page? Not sure if Nexus currently exposes the needed info for this anywhere?

@buberdds buberdds force-pushed the mz/nodeAddr branch 2 times, most recently from d82760d to 5f676a4 Compare May 16, 2025 17:29
<dt>{t('common.nodeAddress')}</dt>
<dd>
<AccountLink
alwaysTrimOnTablet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alwaysTrimOnTablet can be removed when highlighting is fixed

@buberdds
Copy link
Contributor Author

Links rendered instead of lables. The second part will be moved to another PR once Nexus support filtering validators by node_addr

@buberdds buberdds marked this pull request as ready for review May 16, 2025 17:33
)
}
case NodeDisplayType.Id:
default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would check that type is exhausted

@buberdds buberdds merged commit 224589f into master May 20, 2025
9 checks passed
@buberdds buberdds deleted the mz/nodeAddr branch May 20, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show addresss of Node IDs
3 participants