Rename validator_node_for -> entity_node_for #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/rename
branch
from
edbc8f5 to
881a99b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR renames validator-related fields to entity-related fields to better represent the current use case.
- Renames JSON keys in multiple e2e regression tests.
- Updates client queries, client handling, API spec, and changelog to use the new entity naming.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e_regression/eden_testnet_2025/expected/validator_node_account.body | Renames "validator_node_for" to "entity_node_for". |
| tests/e2e_regression/eden_2025/expected/account_with_tx.body | Renames "validator_entity" to "entity" and updates key naming. |
| tests/e2e_regression/eden/expected/account_with_tx.body | Same renaming as above. |
| tests/e2e_regression/damask/expected/account_with_tx.body | Same renaming as above. |
| storage/client/queries/queries.go | Updates query constant and alias names to reflect changes. |
| storage/client/client.go | Renames local variables and scanned values to use entity terminology. |
| api/spec/v1.yaml | Replaces validator field names with entity field names. |
| .changelog/1003.feature.md | Documents the renaming changes following the new naming convention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.