Skip to content

api/runtime_transactions: Optimize related accounts filtering #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Apr 9, 2025

Analogous to #967 but for runtime transactions.

@ptrus ptrus requested a review from Copilot April 9, 2025 14:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • tests/e2e_regression/damask/expected/emerald_txs_by_related_account.body: Language not supported
  • tests/e2e_regression/damask/expected/emerald_txs_by_related_account.headers: Language not supported
  • tests/e2e_regression/damask/expected/emerald_txs_by_related_account_and_method.body: Language not supported
  • tests/e2e_regression/damask/expected/emerald_txs_by_related_account_and_method.headers: Language not supported
  • tests/e2e_regression/damask/test_cases.sh: Language not supported
  • tests/e2e_regression/eden/expected/emerald_txs_by_related_account.headers: Language not supported
  • tests/e2e_regression/eden/expected/emerald_txs_by_related_account_and_method.headers: Language not supported
  • tests/e2e_regression/eden/test_cases.sh: Language not supported
  • tests/e2e_regression/eden_testnet_2025/expected/sapphire_txs_by_related_account.headers: Language not supported
  • tests/e2e_regression/eden_testnet_2025/expected/sapphire_txs_by_related_account_and_method.headers: Language not supported
  • tests/e2e_regression/eden_testnet_2025/test_cases.sh: Language not supported
Comments suppressed due to low confidence (2)

storage/client/client.go:1692

  • There is a spelling mistake in the error message; 'to many methods' should be corrected to 'too many methods'.
return nil, fmt.Errorf("to many methods in the method filter")

storage/client/client.go:1691

  • The method filter threshold was reduced from 20 to 8; please verify that this change is intentional and aligns with the API design.
if p.Method != nil && len(*p.Method) > 8 {

@ptrus ptrus force-pushed the ptrus/feature/runtime-transactions-optimize branch from ac29ee3 to 2c3dcd5 Compare April 9, 2025 14:06
@ptrus ptrus force-pushed the ptrus/feature/runtime-transactions-optimize branch from 2c3dcd5 to 57ca9ab Compare April 9, 2025 14:11
@ptrus ptrus merged commit ae8249b into main Apr 9, 2025
18 checks passed
@ptrus ptrus deleted the ptrus/feature/runtime-transactions-optimize branch April 9, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant