Skip to content

go/consensus/cometbft/api: Simplify consensus service client #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Apr 7, 2025

This will remove DeliverCommand from consensus ServiceClient, making the API more clean and limited only to two methods DeliverBlock and DeliverEvents. As a result, anyone with access to blocks and events can now run the client.

Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit e1842bc
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/67f59986012e580008f6213f

@peternose peternose force-pushed the peternose/trivial/simplify-service-client branch 3 times, most recently from 547a5cb to cc06b05 Compare April 8, 2025 01:06
@peternose peternose marked this pull request as ready for review April 8, 2025 01:57
@peternose peternose requested a review from martintomazic April 8, 2025 08:29
@peternose peternose force-pushed the peternose/trivial/simplify-service-client branch from cc06b05 to 67994e4 Compare April 8, 2025 09:07
@peternose peternose force-pushed the peternose/trivial/simplify-service-client branch from 67994e4 to db455f9 Compare April 8, 2025 16:03
Copy link
Contributor

@martintomazic martintomazic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hats of for this PR(!), as it simplifies our code significantly.

I left one minor question... :)

@peternose peternose force-pushed the peternose/trivial/simplify-service-client branch from db455f9 to e1842bc Compare April 8, 2025 21:47
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 75.69061% with 44 lines in your changes missing coverage. Please review.

Project coverage is 65.12%. Comparing base (a97e93e) to head (e1842bc).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
go/consensus/cometbft/roothash/roothash.go 68.18% 23 Missing and 5 partials ⚠️
go/consensus/cometbft/full/services.go 88.00% 4 Missing and 5 partials ⚠️
go/consensus/cometbft/full/archive.go 20.00% 3 Missing and 1 partial ⚠️
go/consensus/cometbft/full/full.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6137      +/-   ##
==========================================
- Coverage   65.26%   65.12%   -0.15%     
==========================================
  Files         637      637              
  Lines       64575    64524      -51     
==========================================
- Hits        42147    42022     -125     
- Misses      17539    17579      +40     
- Partials     4889     4923      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peternose peternose merged commit c2a3b9b into master Apr 9, 2025
6 of 7 checks passed
@peternose peternose deleted the peternose/trivial/simplify-service-client branch April 9, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants