-
Notifications
You must be signed in to change notification settings - Fork 130
go/consensus/cometbft/api: Simplify consensus service client #6137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
547a5cb
to
cc06b05
Compare
cc06b05
to
67994e4
Compare
67994e4
to
db455f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hats of for this PR(!), as it simplifies our code significantly.
I left one minor question... :)
db455f9
to
e1842bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6137 +/- ##
==========================================
- Coverage 65.26% 65.12% -0.15%
==========================================
Files 637 637
Lines 64575 64524 -51
==========================================
- Hits 42147 42022 -125
- Misses 17539 17579 +40
- Partials 4889 4923 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This will remove
DeliverCommand
from consensusServiceClient
, making the API more clean and limited only to two methodsDeliverBlock
andDeliverEvents
. As a result, anyone with access to blocks and events can now run the client.