go/consensus/api: Add method GetLatestHeight #6144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
peternose
force-pushed
the
peternose/feature/latest-height
branch
from
05e2f77 to
399ca36
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6144 +/- ##
==========================================
- Coverage 65.12% 64.84% -0.28%
==========================================
Files 637 637
Lines 64524 64544 +20
==========================================
- Hits 42022 41855 -167
- Misses 17579 17826 +247
+ Partials 4923 4863 -60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
ptrus
approved these changes
Apr 9, 2025
| @@ -184,11 +190,11 @@ var ( | |||
| ) | |||
|
|
|||
| func handlerSubmitTx( | |||
| srv interface{}, | |||
| srv any, | |||
There was a problem hiding this comment.
Should we do a commit that updates these across all grpc backends?
There was a problem hiding this comment.
Actually, I can replace it everywhere, except in aesm_proto.pb.go.
peternose
force-pushed
the
peternose/feature/latest-height
branch
2 times, most recently
from
d146a6b to
fdb6498
Compare
peternose
force-pushed
the
peternose/feature/latest-height
branch
from
fdb6498 to
0b8ad17
Compare
kostko
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.