-
Notifications
You must be signed in to change notification settings - Fork 130
go/consensus/api: Add method GetBlockResults #6180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
90a4447
to
d9d120c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6180 +/- ##
==========================================
- Coverage 64.36% 64.31% -0.05%
==========================================
Files 646 651 +5
Lines 65217 65266 +49
==========================================
- Hits 41979 41978 -1
- Misses 18350 18393 +43
- Partials 4888 4895 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d9d120c
to
2e81660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to open an issue to benchmark the difference (if any) before release.
2e81660
to
9dd8dd2
Compare
Maybe it is easier to just optimize for full nodes. See the last commit. |
9dd8dd2
to
246a058
Compare
Method
GetBlockResults
is needed by the light client node to serve events.If performance degrades due to unmarshalling block results metadata in every
GetEvents
call, we can retain the backend interface and useGetCometBFTBlockResults
if implemented, falling back toGetBlockResults
otherwise.