Skip to content

go/runtime: Add log manager #6197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

go/runtime: Add log manager #6197

merged 2 commits into from
May 27, 2025

Conversation

kostko
Copy link
Member

@kostko kostko commented May 20, 2025

Fixes #6064

Copy link

netlify bot commented May 20, 2025

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit fb9db6f
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-oasis-core/deploys/683581c448506500088bf8c9

@kostko kostko force-pushed the kostko/feature/log-manager branch 4 times, most recently from 891f6e5 to 805b3c3 Compare May 20, 2025 13:03
@kostko kostko force-pushed the kostko/feature/log-manager branch 4 times, most recently from af44f31 to e8231ee Compare May 22, 2025 08:34
@kostko kostko marked this pull request as ready for review May 22, 2025 10:39
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 55.71956% with 120 lines in your changes missing coverage. Please review.

Project coverage is 64.54%. Comparing base (031d550) to head (6f01518).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
go/runtime/registry/host_rofl_mgmt.go 0.00% 40 Missing ⚠️
go/runtime/log/log.go 67.50% 21 Missing and 5 partials ⚠️
go/runtime/log/manager.go 51.02% 22 Missing and 2 partials ⚠️
go/runtime/host/protocol/connection.go 41.66% 7 Missing ⚠️
go/runtime/registry/host_rofl.go 0.00% 5 Missing ⚠️
go/common/logging/filter.go 77.77% 2 Missing and 2 partials ⚠️
go/runtime/config/config.go 55.55% 2 Missing and 2 partials ⚠️
go/runtime/host/logger.go 72.72% 3 Missing ⚠️
go/runtime/host/protocol/metrics.go 50.00% 3 Missing ⚠️
go/runtime/registry/host.go 57.14% 2 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6197      +/-   ##
==========================================
- Coverage   65.17%   64.54%   -0.64%     
==========================================
  Files         651      658       +7     
  Lines       65295    65541     +246     
==========================================
- Hits        42559    42306     -253     
- Misses      17905    18296     +391     
- Partials     4831     4939     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kostko kostko force-pushed the kostko/feature/log-manager branch 3 times, most recently from ea3fd2d to 70f41a0 Compare May 23, 2025 09:10
@kostko kostko force-pushed the kostko/feature/log-manager branch from 70f41a0 to 45f501f Compare May 26, 2025 11:01
@kostko kostko force-pushed the kostko/feature/log-manager branch from 45f501f to 6f01518 Compare May 26, 2025 12:03
@kostko kostko force-pushed the kostko/feature/log-manager branch from 6f01518 to fb9db6f Compare May 27, 2025 09:11
@kostko kostko merged commit 9e53794 into master May 27, 2025
3 of 5 checks passed
@kostko kostko deleted the kostko/feature/log-manager branch May 27, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add endpoints to stream logs from a given runtime component
3 participants