go/p2p/peermgmt: Make consensus peer registry optional #6202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
This change allows the P2P service to operate independently of the consensus layer by discovering peers solely through peer discovery mechanisms. Fetching peers from the consensus registry is now optional and can be enabled if the consensus service is available.
peternose
force-pushed
the
peternose/trivial/decouple-p2p-consensus
branch
from
f7c592b to
052c7d0
Compare
kostko
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow us to create the P2P service without relying on the consensus. The service can now be instantiated upfront and shared with other components immediately. Previously, the light client could only be initialized lazily, after the P2P service was registered, which was not suitable for a stateless light node.