rofl-scheduler: Add initial ROFL scheduler #2179

kostko · 2025-03-19T11:00:54Z

netlify · 2025-03-19T11:03:45Z

✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.

Name	Link
🔨 Latest commit	`f89a887`
🔍 Latest deploy log	https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/6819f47c074c220008277559

codecov · 2025-03-29T18:35:43Z

Codecov Report

Attention: Patch coverage is 3.44828% with 784 lines in your changes missing coverage. Please review.

Project coverage is 54.10%. Comparing base (56fda77) to head (6647350).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
rofl-scheduler/src/manager.rs	0.00%	550 Missing ⚠️
rofl-scheduler/src/manifest.rs	30.10%	65 Missing ⚠️
rofl-scheduler/src/client.rs	0.00%	63 Missing ⚠️
rofl-scheduler/src/config.rs	0.00%	46 Missing ⚠️
runtime-sdk/src/modules/rofl/app/client.rs	0.00%	26 Missing ⚠️
runtime-sdk/src/storage/host.rs	0.00%	15 Missing ⚠️
rofl-scheduler/src/main.rs	0.00%	11 Missing ⚠️
runtime-sdk/src/modules/rofl/app/env.rs	0.00%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
- Coverage   58.90%   54.10%   -4.81%     
==========================================
  Files         151      156       +5     
  Lines       11333    12123     +790     
==========================================
- Hits         6676     6559     -117     
- Misses       4657     5564     +907

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

peternose

Left few comments, will have another look once we merge the other PR.

.github/workflows/release-rofl-scheduler.yml

rofl-scheduler/rofl.yaml

peternose · 2025-04-17T09:41:03Z

rofl-scheduler/Cargo.toml

+[package]
+name = "rofl-scheduler"
+version = "0.1.0"
+edition = "2021"


rofl-scheduler/src/manifest.rs

peternose · 2025-04-17T10:59:54Z

rofl-scheduler/src/manifest.rs

+    #[default]
+    #[serde(skip)]
+    #[cbor(skip)]
+    Invalid,


Is this necessary?

rofl-scheduler/src/manager.rs

ptrus

First pass, the main scheduler loop looks sound!

rofl-scheduler/src/client.rs

rofl-scheduler/src/config.rs

rofl-scheduler/src/manager.rs

peternose · 2025-04-18T20:36:17Z

rofl-scheduler/src/manager.rs

+                    "id" => ?instance.id,
+                    "creator" => instance.creator,
+                );
+                local_state


Is this step needed? Same below.

Yes, otherwise the unaccepted instances will never be removed. The idea is that scheduler instances will fuzzily remove instances they reject. So if no scheduler instance accepts an instance it will eventually be removed.

peternose · 2025-04-18T20:40:28Z

rofl-scheduler/src/manager.rs

+            })
+            .collect();
+
+        for instance in instances {


Should we also check if the instance is paid?

When you create the instance you must also pay the initial term (this is enforced by the marketplace). Otherwise the instance will not even be created. The scheduler has some time to accept an instance, otherwise it can be cancelled and refunded.

rofl-scheduler/src/manager.rs

rofl-scheduler/src/client.rs

rofl-scheduler/src/manager.rs

rofl-scheduler/src/client.rs

rofl-scheduler/src/manager.rs

ptrus · 2025-05-06T08:00:29Z

rofl-scheduler/src/manager.rs

+                    slog::error!(self.logger, "task failed"; "err" => ?err);
+                }
+                Ok(Ok(_)) => {
+                    // Ok.


Should we add some debug logging here for each finished task? Might be helpful for debugging in case there would be issues with specific tasks executing/blocking for long time?

…ostko/feature/rofl-scheduler rofl-scheduler: Add initial ROFL scheduler 28069c3

…/kostko/feature/rofl-scheduler rofl-scheduler: Add initial ROFL scheduler 28069c3

…sisprotocol/kostko/feature/rofl-scheduler rofl-scheduler: Add initial ROFL scheduler 28069c3

…oasisprotocol/kostko/feature/rofl-scheduler rofl-scheduler: Add initial ROFL scheduler 28069c3

kostko force-pushed the kostko/feature/rofl-scheduler branch 4 times, most recently from f214f75 to 11c28a4 Compare March 26, 2025 17:40

kostko force-pushed the kostko/feature/rofl-scheduler branch 2 times, most recently from fe07946 to 1068e66 Compare March 29, 2025 18:21

kostko force-pushed the kostko/feature/rofl-scheduler branch 6 times, most recently from 203ea1a to d7d878f Compare April 10, 2025 09:49

kostko force-pushed the kostko/feature/rofl-scheduler branch 5 times, most recently from 496f7b8 to ce6d4df Compare April 14, 2025 14:27

kostko marked this pull request as ready for review April 14, 2025 14:27

kostko requested review from pro-wh, ptrus and peternose as code owners April 14, 2025 14:27

kostko force-pushed the kostko/feature/rofl-scheduler branch from ce6d4df to e806c6d Compare April 14, 2025 16:49

kostko mentioned this pull request Apr 15, 2025

Allow a component to manage bundles oasisprotocol/oasis-core#6119

Merged

kostko force-pushed the kostko/feature/rofl-scheduler branch 5 times, most recently from 64000d2 to 47e618e Compare April 17, 2025 14:47

kostko force-pushed the kostko/feature/rofl-scheduler branch 3 times, most recently from f329364 to ebd4a1c Compare April 17, 2025 15:37

peternose reviewed Apr 17, 2025

View reviewed changes

kostko force-pushed the kostko/feature/rofl-scheduler branch 2 times, most recently from b9e5264 to ced75bb Compare April 18, 2025 08:26

ptrus reviewed Apr 18, 2025

View reviewed changes

rofl-scheduler/src/client.rs Outdated Show resolved Hide resolved

rofl-scheduler/src/config.rs Show resolved Hide resolved

rofl-scheduler/src/manager.rs Outdated Show resolved Hide resolved

peternose reviewed Apr 18, 2025

View reviewed changes

kostko force-pushed the kostko/feature/rofl-scheduler branch 6 times, most recently from d2b69ac to 99163cc Compare April 28, 2025 09:37

ptrus reviewed Apr 30, 2025

View reviewed changes

rofl-scheduler/src/client.rs Outdated Show resolved Hide resolved

rofl-scheduler/src/manager.rs Show resolved Hide resolved

kostko force-pushed the kostko/feature/rofl-scheduler branch from 99163cc to b4f876c Compare May 5, 2025 11:43

ptrus approved these changes May 6, 2025

View reviewed changes

kostko force-pushed the kostko/feature/rofl-scheduler branch 2 times, most recently from c0b4f24 to 80b66b6 Compare May 6, 2025 11:28

kostko added 2 commits May 6, 2025 13:37

rofl-scheduler: Add initial ROFL scheduler

bd20d4b

runtime-sdk/modules/rofl/app: Verify transaction inclusion

f89a887

kostko force-pushed the kostko/feature/rofl-scheduler branch from 80b66b6 to f89a887 Compare May 6, 2025 11:37

kostko merged commit 28069c3 into main May 6, 2025
26 checks passed

kostko deleted the kostko/feature/rofl-scheduler branch May 6, 2025 12:04

github-actions bot added a commit that referenced this pull request May 6, 2025

Deploy js API reference Merge pull request #2179 from oasisprotocol/k…

84a2a86

…ostko/feature/rofl-scheduler rofl-scheduler: Add initial ROFL scheduler 28069c3

github-actions bot added a commit that referenced this pull request May 6, 2025

Deploy rust API reference Merge pull request #2179 from oasisprotocol…

3513161

…/kostko/feature/rofl-scheduler rofl-scheduler: Add initial ROFL scheduler 28069c3

github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request May 6, 2025

Deploy js API reference Merge pull request oasisprotocol#2179 from oa…

f95e68e

…sisprotocol/kostko/feature/rofl-scheduler rofl-scheduler: Add initial ROFL scheduler 28069c3

github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request May 6, 2025

Deploy rust API reference Merge pull request oasisprotocol#2179 from …

7547df8

…oasisprotocol/kostko/feature/rofl-scheduler rofl-scheduler: Add initial ROFL scheduler 28069c3

rofl-scheduler: Add initial ROFL scheduler #2179

rofl-scheduler: Add initial ROFL scheduler #2179

Uh oh!

Conversation

kostko commented Mar 19, 2025

Uh oh!

netlify bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.

Uh oh!

codecov bot commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

peternose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

peternose Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

peternose Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ptrus left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peternose Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

kostko Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

peternose Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

kostko Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ptrus May 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Mar 19, 2025 •

edited

Loading

codecov bot commented Mar 29, 2025 •

edited

Loading

ptrus left a comment •

edited

Loading