runtime-sdk/consensus_accounts: Include shares and epoch in delegation events #2226
+217
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2226 +/- ##
==========================================
- Coverage 55.37% 55.36% -0.02%
==========================================
Files 155 155
Lines 11725 11749 +24
==========================================
+ Hits 6493 6505 +12
- Misses 5232 5244 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptrus
force-pushed
the
ptrus/feature/delegation-shares
branch
from
f223b77 to
7cd481f
Compare
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/delegation-shares
branch
from
7cd481f to
a0dddda
Compare
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/delegation-shares
branch
6 times, most recently
from
23216a2 to
e3aaa50
Compare
ptrus
force-pushed
the
ptrus/feature/delegation-shares
branch
from
e3aaa50 to
08406d0
Compare
peternose
approved these changes
May 23, 2025
| @@ -199,6 +214,8 @@ type DelegateEvent struct { | |||
| To types.Address `json:"to"` | |||
| Amount types.BaseUnits `json:"amount"` | |||
| Error *ConsensusError `json:"error,omitempty"` | |||
| // Added in runtime-sdk v0.15.0. | |||
There was a problem hiding this comment.
Will these comments be removed in the future?
There was a problem hiding this comment.
Not sure. As far as I'm concerned, I can also remove the comment now. But for someone looking at the code without this comment, it won't be obvious why this field is potentially empty.
ptrus
force-pushed
the
ptrus/feature/delegation-shares
branch
from
08406d0 to
114ff20
Compare
github-actions bot
added a commit
that referenced
this pull request
May 26, 2025
…trus/feature/delegation-shares runtime-sdk/consensus_accounts: Include shares and epoch in delegation events 595e8b2
github-actions bot
added a commit
that referenced
this pull request
May 26, 2025
…/ptrus/feature/delegation-shares runtime-sdk/consensus_accounts: Include shares and epoch in delegation events 595e8b2
github-actions bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
May 26, 2025
…sisprotocol/ptrus/feature/delegation-shares runtime-sdk/consensus_accounts: Include shares and epoch in delegation events 595e8b2
github-actions bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
May 26, 2025
…oasisprotocol/ptrus/feature/delegation-shares runtime-sdk/consensus_accounts: Include shares and epoch in delegation events 595e8b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DelegateEventalso returns the amount of new shares received by the delegation.UndelegateDoneEventincludes the undelegation epoch.Made it optional so it's backwards compatible (old events can still be deserialized with the type).
Ensure Nexus deployments are updated first, before a paratime with this change is released.