clients/js: Make NETWORKS compatible with wallet_addEthereumChain #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
matevz
force-pushed
the
matevz/features/eth-compatible-networks
branch
from
cc46470 to
1ff6dba
Compare
rube-de
reviewed
Apr 1, 2025
|
This PR needs decision on official icons for Sapphire Mainnet/Testnet. (also, do we separate between Emerald/Sapphire?) |
|
I would unblock this by copying icon 6 times to assets.oasis.io. When decision comes, update it there 🤷 |
matevz
force-pushed
the
matevz/features/eth-compatible-networks
branch
from
1ff6dba to
9fc40e2
Compare
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
matevz
force-pushed
the
matevz/features/eth-compatible-networks
branch
from
9fc40e2 to
2d460ec
Compare
lubej
approved these changes
May 21, 2025
github-actions bot
added a commit
that referenced
this pull request
May 21, 2025
…tevz/features/eth-compatible-networks clients/js: Make NETWORKS compatible with wallet_addEthereumChain a150088
github-actions bot
added a commit
that referenced
this pull request
May 21, 2025
…atevz/features/eth-compatible-networks clients/js: Make NETWORKS compatible with wallet_addEthereumChain a150088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the "Add Sapphire network to Metamask" in the growing number of places (docs, faucet, all the dApps). Since most of those apps explicitly or implicitly import
@oasisprotocol/sapphire-paratime, let's unify the network details in a single place.For now, I made it compatible with https://docs.metamask.io/wallet/reference/json-rpc-methods/wallet_addethereumchain/ so one can directly use it in the UI.
But there seems to be some other competing formats: