Update dappwright dependency and enhance e2e tests for wallet account switching #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rube-de
force-pushed
the
rube/560-ci-fix-intermittent-dappwright-errors
branch
from
36e43bc to
f325ef0
Compare
…e2e tests for wallet account switching
rube-de
force-pushed
the
rube/560-ci-fix-intermittent-dappwright-errors
branch
from
f325ef0 to
2d237d2
Compare
aefhm
approved these changes
Apr 11, 2025
|
just an FYI that the issue you experienced should be fixed in https://github.com/TenKeyLabs/dappwright/releases/tag/v2.10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
examples/wagmi-v2project to improve the test suite and update dependencies. The most important changes include updating the@tenkeylabs/dappwrightdependency and enhancing the end-to-end test script to handle page navigation and account switching more robustly.Dependency updates:
examples/wagmi-v2/package.json: Updated@tenkeylabs/dappwrightdependency from version^2.8.6to^2.10.0which includes the fix for account selection by nameEnhancements to end-to-end tests:
examples/wagmi-v2/test/e2e.spec.ts: Changed account selection from numeric index to account name (wallet.switchAccount("Alice")), based on the fix in Dappwright PR #440. This change resolves the issue where account switching would get stuck on the account selection screen.examples/wagmi-v2/test/e2e.spec.ts: Added logic to store the current URL and handle potential page closures by reopening and navigating back to the application URL if necessary. This ensures the test continues even if the page is closed during the process.