Skip to content

fix: update CI workflows to use corepack and install dependencies with frozen lockfile #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

rube-de
Copy link
Contributor

@rube-de rube-de commented Apr 23, 2025

This pull request streamlines the GitHub Actions workflows, updates dependencies, and introduces a new package.json file for the project. The most notable changes include simplifying the setup of pnpm and caching, updating the viem dependency to a more flexible version range, and adding a package.json file with project metadata and configuration.

Reproducible Builds:

  • all workflows use now pnpm install --frozen-lockfile
  • all workflows use now the package manger from root package.json via pnpm/action-setup@v4

Workflow Simplifications:

  • Replaced the manual setup of pnpm and caching in all workflows (ci-docs, ci-lint, ci-playwright, ci-test, contracts-test, publish) with the cache: 'pnpm' option in actions/setup-node@v4 for improved maintainability. Also removed redundant steps like pnpm store path and actions/cache. [1] [2] [3] [4] [5] [6] [7]

Dependency Updates:

  • Updated the viem dependency in examples/wagmi-v2/package.json and integrations/viem-v2/package.json to use the 2.x version range instead of a specific version, allowing for minor version updates without manual intervention. [1] [2]

Project Configuration:

  • Added a new package.json file at the root of the project with metadata, Node.js version requirements (>=18.0.0), and pnpm configuration, including an override for the elliptic package.
  • Removed the elliptic override from pnpm-workspace.yaml, as it is now managed in the new package.json.

@rube-de rube-de force-pushed the rube/ghaction-pnpm-lockfile branch from af64a34 to eb7d7f3 Compare April 23, 2025 15:29
Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
🔨 Latest commit af64a34
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/680907609e189c0008eea586

Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
🔨 Latest commit 4579ce1
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/680fc8ff91e54000083764b9

@rube-de rube-de requested review from matevz, lukaw3d and lubej April 23, 2025 20:04
@rube-de rube-de marked this pull request as ready for review April 23, 2025 20:05
@rube-de rube-de force-pushed the rube/ghaction-pnpm-lockfile branch from 9434c6d to 8c1c90f Compare April 23, 2025 20:06
@rube-de rube-de force-pushed the rube/ghaction-pnpm-lockfile branch from 156c2d8 to 8c1c90f Compare April 25, 2025 05:28
@rube-de rube-de force-pushed the rube/ghaction-pnpm-lockfile branch from cd7d78a to 900ad22 Compare April 28, 2025 13:53
@rube-de rube-de force-pushed the rube/ghaction-pnpm-lockfile branch from 54b5a41 to 4579ce1 Compare April 28, 2025 18:29
@rube-de rube-de requested a review from lukaw3d April 28, 2025 18:29
@rube-de rube-de merged commit 7fa79c8 into main Apr 29, 2025
15 checks passed
@rube-de rube-de deleted the rube/ghaction-pnpm-lockfile branch April 29, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants