clients/js: Don't throw on eth_chainId request on non-sapphire chain #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 10, 2025 03:53
I think do we want to crash if user tries to make an encrypted transaction using our wrapper while metamask is connected to non-sapphire chains. But we shouldn't crash on non-sensitive methods that are needed to switch chains.
`eth_call` to 0x0100000000000000000000000000000000000103 returns 0x instead of throwing. So if metamask was connected to a non-sapphire chain and sdk tried to fetch public key, then it was throwing 'too short' in parseAbiEncodedUintBytes.
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
lubej
approved these changes
May 10, 2025
|
This didn't affect https://vote.oasis.io/#/. It makes these requests using unwrapped provider |
|
Seems to affect https://0x2fa.com/ |
github-actions bot
added a commit
that referenced
this pull request
May 18, 2025
…/fix-nonsapphire clients/js: Don't throw on eth_chainId request on non-sapphire chain bfc0d00
github-actions bot
added a commit
that referenced
this pull request
May 18, 2025
…w/fix-nonsapphire clients/js: Don't throw on eth_chainId request on non-sapphire chain bfc0d00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #583