Skip to content

Conversation

galois17
Copy link
Contributor

@galois17 galois17 commented Nov 3, 2020

Should only use no_verify when no_verify: false is passed as an option to OAuth::Consumer.new

@galois17 galois17 requested review from pboling and xtagon November 23, 2020 19:38
@xtagon
Copy link
Contributor

xtagon commented Nov 24, 2020

LGTM but we should probably have @pboling sign off on it too.

Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboling pboling merged commit 93602bc into ruby-oauth:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants