Only validate tokens if ValidateURL resolves to a non-empty string #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
changed the title
jonas
force-pushed
the
check-against-validate-url-string
branch
2 times, most recently
from
93f2d23 to
af553bf
Compare
Fix an unsupported protocol scheme error when validating tokens by
ensuring that the ValidateURL generates a non-empty string. The Azure
provider doesn't define any ValidateURL and therefore uses the default
value of `url.Parse("")` which is not `nil`.
The following log summary shows the issue:
2019/06/14 12:26:04 oauthproxy.go:799: 10.244.1.3:34112 ("10.244.1.1") refreshing 16h26m29s old session cookie for Session{email:jonas.fonseca@example.com user:jonas.fonseca token:true} (refresh after 1h0m0s)
2019/06/14 12:26:04 internal_util.go:60: GET ?access_token=eyJ0...
2019/06/14 12:26:04 internal_util.go:61: token validation request failed: Get ?access_token=eyJ0...: unsupported protocol scheme ""
2019/06/14 12:26:04 oauthproxy.go:822: 10.244.1.3:34112 ("10.244.1.1") removing session. error validating Session{email:jonas.fonseca@example.com user:jonas.fonseca token:true}
jonas
force-pushed
the
check-against-validate-url-string
branch
from
af553bf to
7a8fb58
Compare
JoelSpeed
approved these changes
Jun 15, 2019
There was a problem hiding this comment.
Just had a look through the code and this basically acts as a shortcut for a case we know will always fail. It skips us attempting to make a request so seems like a strict improvement and the test for the empty validateURL expects a false answer anyway, so I think this is good! Thanks for the fix!
|
Thanks @JoelSpeed for the quick turn-around. This project has been invaluable. I will look into also updating the documentation for the Azure provider. They recently changed the Azure portal and the required |
T-vK
pushed a commit
to T-vK/oauth2-proxy
that referenced
this pull request
Nov 20, 2024
…2-proxy Upgrade to the latest version of OAuth2-Proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an unsupported protocol scheme error when validating tokens by
ensuring that the ValidateURL generates a non-empty string. The Azure
provider doesn't define any ValidateURL and therefore uses the default
value of
url.Parse("")which is notnil.Motivation and Context
The following log summary shows the issue:
How Has This Been Tested?
No.
Checklist: