Add new linters #486
Merged
Add new linters #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johejo
requested review from
JoelSpeed,
steakunderscore and
loshz
as code owners
JoelSpeed
reviewed
Apr 13, 2020
oauthproxy.go
Outdated
| } | ||
| var u url.URL | ||
| u = *p.redirectURL | ||
| var u url.URL = *p.redirectURL |
There was a problem hiding this comment.
Suggested change
| var u url.URL = *p.redirectURL | |
| u := *p.redirectURL |
providers/logingov.go
Outdated
| func (p *LoginGovProvider) GetLoginURL(redirectURI, state string) string { | ||
| var a url.URL | ||
| a = *p.LoginURL | ||
| var a url.URL = *p.LoginURL |
There was a problem hiding this comment.
Suggested change
| var a url.URL = *p.LoginURL | |
| a := *p.LoginURL |
providers/provider_default.go
Outdated
| func (p *ProviderData) GetLoginURL(redirectURI, state string) string { | ||
| var a url.URL | ||
| a = *p.LoginURL | ||
| var a url.URL = *p.LoginURL |
There was a problem hiding this comment.
Suggested change
| var a url.URL = *p.LoginURL | |
| a := *p.LoginURL |
.golangci.yml
Outdated
| - bodyclose | ||
| - dogsled | ||
| - goprintffuncname | ||
| - interfacer |
There was a problem hiding this comment.
I know interfacer is deprecated so please remove this one
3 tasks
Jing-ze
pushed a commit
to Jing-ze/oauth2-proxy
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable some linters and fix issues.
Fixed some deprecated and dangerous code.
I chose linter carefully, but would like to respect the opinions of the maintainers, so please let me know thoughts.
Motivation and Context
We want to make incremental improvements to maintain our code in a sustainable way.
This is the first step.
How Has This Been Tested?
make testChecklist: