Make sure websockets respect ssl-upstream-insecure-skip-verify setting. #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaroslav Rosomakho <yaroslavros@gmail.com>
yaroslavros
requested review from
JoelSpeed,
steakunderscore and
loshz
as code owners
JoelSpeed
reviewed
Apr 18, 2020
…ecure-skip-verify Signed-off-by: Yaroslav Rosomakho <yaroslavros@gmail.com>
|
Updated changelog as requested |
steakunderscore
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes websockets follow the same certificate validation behaviour as HTTPS.
Motivation and Context
Without this change, websockets have to work over HTTP or always require valid TLS certificate even when ssl-upstream-insecure-skip-verify setting is set.
With this change, websockets TLS verification matches HTTPS.
How Has This Been Tested?
Made a build, verified that websockets now follow same certificate validation rules as HTTPS.
Checklist:
Signed-off-by: Yaroslav Rosomakho yaroslavros@gmail.com
Fixes #493