Add basic string functions to templates #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
reviewed
May 6, 2020
templates.go
Outdated
| "ToUpper": strings.ToUpper, | ||
| "ToLower": strings.ToLower, | ||
| } | ||
| logger.Printf("using custom template directory %q", dir) |
There was a problem hiding this comment.
This log line is duplicated with line 15
There was a problem hiding this comment.
I’ll take a stab at a test. Not sure how I missed that duplicate logging entry...
There was a problem hiding this comment.
sorry about the lint error.. I used gitpod and my editor settings weren't configured there to format on save
* add gitea to auth config docs * PR feedback Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
steakunderscore
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to add functions to templates. Currently supports modifying a variable to all uppercase or all lowercase.
Usage:
{{.ProviderName | ToLower}} {{.ProviderName | ToUpper}}
Motivation and Context
I designed a template for oauth2-proxy which dynamically displays the provider login button based on the provider name using standard external CSS libraries. The required class names are btn-{{lowercaseProvider}}. Rather than create new variables to pass in to the template, the better solution seemed to be to allow the template engine to use basic string functions like ToUpper and ToLower.
HTML templates using external libraries may need to use the provider name in a class. As classes generally cannot be renamed unless a pre-processor like SASS or LESS is used, modifying the variable in the template is the best option.
How Has This Been Tested?
A template has been created which requires lowercase class names for the provider to display the provider logo using font-awesome.
Checklist: