Separate logging options out of main options structure

[JoelSpeed]

Description

Creates a LoggingOptions struct and moves all details required for configuring Logging to this struct, plus a LoggingFlagSet, plus a Default function.

Motivation and Context

This is a step towards having a structured configuration. We can move options internally without breaking the external config while we try and create a structure that we are happy with.

I've added a test that checks the defaulting when no options are given, but this will eventually be covered by the tests in #489 once that is merged

How Has This Been Tested?

It's a refactor of internal code, tests pass so all should be fine.

Checklist:

• My change requires a change to the documentation or CHANGELOG.
• I have updated the documentation/CHANGELOG accordingly.
• I have created a feature (non-master) branch for my PR.

[steakunderscore]

Should we be adding tests for this code?

[steakunderscore]

This isn't quite correct. Shouldn't it be "Splitting logging options from global options structure"

[JoelSpeed]

Rebase problems 😅 Will fix

[JoelSpeed]

Technically it's all covered by the existing tests, but I will make sure to add some tests specifically for the logging validation. Will need to see how easy it is to actually test this though as a lot of the options set private members 🤔

[JoelSpeed]

Rebase problems 😅 Will fix

[JoelSpeed]

@steakunderscore I've had a look at doing testing for this, ideally I would like to have the configureLogger in the actual logger package (since it's not really validating anything, just configuring), but this lead to many import cycle errors.

It's made me realise that the Options structure and the validation is rather overloaded, we should try to remove the mutation from the validate function and instead, just validate. This would involve removing the private members of the Options struct and instead making those members of the main structure (for now). I'll look into this tomorrow as I think it might simplify a lot of things.

Note, I also added an extra commit onto the end of this because I noticed the exclude paths option was inconsistent with our other options

[steakunderscore]

I'm happy for tests to come later. Thanks.

[JoelSpeed]

Rebased to fixup changelog conflict, no other changes, so going to treat this as already approved