Stop accepting legacy SHA1 signed cookies #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as WIP for now Want to make it easier to spot that we don't want it merged until after the 6.0.0 release How long we should actually support both signatures for I'm not yet sure |
3 tasks
|
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
|
This is gonna happen! Soon, I promise. |
NickMeves
force-pushed
the
deprecate-sha1
branch
from
e3b3832 to
1f6ae92
Compare
|
Rebased -- ready for the v7 flood of breaking changes PR merges! |
NickMeves
force-pushed
the
deprecate-sha1
branch
from
1f6ae92 to
56f199a
Compare
3 tasks
Jing-ze
pushed a commit
to Jing-ze/oauth2-proxy
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this in the wings so we don't forget 😄
Related to #524
Stop accepting legacy SHA1 signed cookies after new SHA256 signed cookies have rolled out.
Description
After a rollout graceful rollout window of SHA256 signed cookies, we need to eventually stop accepting SHA1 cookies to get the security benefit.
Motivation and Context
Until SHA1 signatures are not accepted, session cookies are still weak to the newer SHA1 attacks that are emerging since ~2017.
How Has This Been Tested?
Unit tests updated.
Checklist:
(Waiting on CHANGELOG for now since I imagine we'll target this for a later quarterly release?)