Hacking On The Mozilla Authenticator-RS Backend For SSHCerts #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obelisk
force-pushed
the
hacking_on_mozilla
branch
from
08ae38f
to
1ffd304
Compare
* Limit the size of attestation certs * Use authority returned from x509 approval response * x509 authorization checks authority for local-db mode * Fix test configs
* Add feature to fetch a list of signers and their pubkeys * Refactor * Update CLI output * Add authorized signers cache * Add compression to authorized signers * Switch to zstd * Refactor * Update local testdb * Add LRU rate limiter * Remove output line * FFI * Remove line * Move to SSHCerts 13.1 * Add new FFIs for data signing and verification * Fix agent * Rename authorized signers to allowed signers * Restrict sshcerts features in rustica to remove openssl * A missing s makes everyone sad * Yubikey lite you idiot * Rename * Fix return code --------- Co-authored-by: Mitchell Grenier <mitchell@confurious.io>
* Add get_cert function to Agent handler * Add get_cert * Fix get_cert FFI * Reuse runtime
…update issuance CN to match what is expected in server code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a lot more flexibility for key selection and tying it to development of Firefox is probably good for long term updates and support of new CTAP2 features.
Currently this relies on a patch of authenticator-rs, which is available through a patch of sshcerts so definitely not ready for primetime.
This is also dependent on the multithreading fix by @timweri