duplicate results in queries

[rootandy]

I have more than one condition like

myObjectBox.query()
.equal(MyObject_.relatedObjectId, 1)
.less(MyObject_.date, date)
.build().findIds()

on a object collection like

{id, relatedObjectId, date}
{1,1,2017-05-20},
{2,1,2017-05-21},
{3,1,2017-05-22},
{4,1,2017-05-23},

with date {2017-05-22} (including some time) i get the following result {1,2,3,1}

Why the hell is there a 1? I tried "life" on a debugger with an additional comparison to the relatedObject and got the result {1,1,2,3} - still not the thing i want to get. If I try to order them I get the error, that I just can use this option on unordered requests. That is strange and think its an issue. If I am wrong, tell me what I do wrong (the code is nearly a copy with some anonymizing of the variables)

[greenrobot]

Can you post some more code? That would make it easier for us to reproduce. Thanks!

[rootandy]

I have objects like

public class RelatedObject {
@Id
private Long id;
}

public class MyObject {
@Id
private Long id;
private long relatedObjectId;
private Date date;

@Relation
RelatedObject relatedObject;
}

and have (for testing) one instance of RelatedObject(id=1) and a few of MyObject(ids=1,2,3,4). And every query i make on MyObject that has RelatedObject as a parameter, will return the first instance of MyObject two times (As I said before the result set is like 1,2,3,4,1 and not as it should be: 1,2,3,4).

[Martinsos]

Hi @rootandy!
I am trying to replicate this bug in a repeatable way and may need more help from you.
Based on the information you provided so far, I wrote the following code:

@Entity
public class Data {
    @Id
    private long id;

    private Date date;
    public Date getDate() { return date; }
    public void setDate(Date date) { this.date = date; }

    private long relatedDataId;

    @Relation
    RelatedData relatedData;
}

@Entity
public class RelatedData {
    @Id
    private long id;
}

...

// Fetch the boxes.
BoxStore boxStore = MyObjectBox.builder().androidContext(appContext).build();
Box<Data> dataBox = boxStore.boxFor(Data.class);
Box<RelatedData> relatedDataBox = boxStore.boxFor(RelatedData.class);

// Clean up the boxes.
dataBox.removeAll();
relatedDataBox.removeAll();

// Add one object that will be related to.
RelatedData rData = new RelatedData();
relatedDataBox.put(rData);

// Add 4 objects that relate to that one object and have different dates.
Date date = new Date();
for (int i = 0; i < 4; i++) {
    Data data = new Data();
    data.setDate(addTime(date, i, 0));
    data.setRelatedData(rData);
    dataBox.put(data);
}

long ids[] = dataBox.query().equal(Data_.relatedDataId, 1)
                    .less(Data_.date, addTime(date, 2, 3)).build().findIds();
// This assert is successful.
assertArrayEquals(new long[]{1, 2, 3}, ids);

...

However, I was not able to replicate the bug: ids 1, 2, 3 are returned, as expected.
Version of objectbox I was testing this on is 0.9.13.

Few questions that I believe should help us:

1. What is the version of objectbox you were testing this on?
2. Can you try running it on a version 0.9.13 and check if the bug still exists?
3. How is your case different than the code that I provided?
   If we can pinpoint those differences, I will probably be able to replicate it.
   Can you replicate the bug in the way similar to as how I tried to do it and provide me with the exact steps and code of the entities?

Thanks!

[rootandy]

Hi,

1. I tested it first on 0.9.12.1 but
2. i already tried on 0.9.13 and yes the bug still exists.
3. For sure I have a bigger project, but when I remove the relation from the query I get the correct result (just the expected results), but as soon as I readd the relation aspect to the query I again get the first result double (when I sort the result the id is for sure two times at the start) - for now i have very much to do but in a week or so I can create a small app upload the code to show the problem to you. - For now i created the workaround at display time to check whether the result is doubled

[Martinsos]

Thanks for quick response @rootandy!
I understand -> the tricky part is that I have nothing to go on from here, I replicated the situation that you described but still can not get an error. I guess it has to do something with the rest of the project (or maybe with how you create the objects?). I will wait for you to provide more information when you catch some time (either more code snippets, showing creating of entities and exactly how are they used, or ideally small app that you mentioned).

[smith6k]

Please have a look at this sample project: https://github.com/smith6k/ObjectBoxDuplicateResult

These are my logs

08-15 02:38:02.345 2592-2592/? I/testing: ===============================
08-15 02:38:02.345 2592-2592/? I/testing: create one of each entity
08-15 02:38:02.350 2592-2592/? I/testing: total Set entities: 1
08-15 02:38:02.350 2592-2592/? I/testing: total Element entities: 1
08-15 02:38:02.350 2592-2592/? I/testing: total ElementAttributes entities: 1
08-15 02:38:02.350 2592-2592/? I/testing: load set with id: 1
08-15 02:38:02.350 2592-2592/? I/testing: set has #elements: 2
08-15 02:38:02.351 2592-2592/? I/testing: set.elementId: 1
08-15 02:38:02.351 2592-2592/? I/testing: set.elementId: 1
08-15 02:38:02.351 2592-2592/? I/testing: ===============================
08-15 02:38:02.351 2592-2592/? I/testing: create one of each entity
08-15 02:38:02.352 2592-2592/? I/testing: total Set entities: 2
08-15 02:38:02.352 2592-2592/? I/testing: total Element entities: 2
08-15 02:38:02.352 2592-2592/? I/testing: total ElementAttributes entities: 2
08-15 02:38:02.352 2592-2592/? I/testing: load set with id: 1
08-15 02:38:02.353 2592-2592/? I/testing: set has #elements: 1
08-15 02:38:02.353 2592-2592/? I/testing: set.elementId: 1

First time the set has two elements with same id, after creating another, it has one, just as it should be.
What is the issue here?

[greenrobot]

@smith6k Thanks. We could replicate using your code and are working on it.

[greenrobot]

@smith6k We think we think we fixed your issue - you can try version '0.9.16-SNAPSHOT' to verify.

Not sure if that helps with the original issue; @rootandy: do you happen to have additional info by now?

[smith6k]

I tried with this snapshot and the sample app from above. It still gives the same logs. I am using snapshot in both gradle files, cleaned the project, deleted objectbox-models, uninstalled sample app and ran the project. Can I do more on my part?

[rootandy]

hi, thank you for your time to try to fix - I will try the snapshot later during the day. I have very much to do during the last weeks and it will not change for the next few weeks - so maybe I will not have time for a sample app during the next 2 weeks. sorry. But I will try the fix as soon as possible.

[greenrobot]

@smith6k @rootandy Sorry, something Maven-ish got confused with the SNAPSHOT I think. Please try 0.9.16-RC. For me this fixed @smith6k issue, and it might help with the other one as well.

[rootandy]

ok I just realized I have to reorder my code (since I did not introduce 0.9.14 by now, which removes the in-place generation and now I have to remove the generated code :( ) so maybe during the next few days I am able to test the new version. Sorry.

[greenrobot]

@rootandy For pre-0.9.14 code, you could try the legacy plugin (apply plugin: 'io.objectbox.legacy'), which is still available in 0.9.16.

[smith6k]

I can confirm that this solved my issues of having duplicates in results.