Add symbols for BDS terms #1808
Conversation
|
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsIAO_0000028
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsL2/3 bipolar vip GABAergic cortical interneuron (Mmus)
|
|
#gogoeditdiff |
|
Not sure why, but it isnt importing IAO_0000028 (symbol) in despite it being present in the term file. |
|
IAO annotations are all on OMO. It needs to add to the import list. |
|
I can create a PR adding the OMO import. |
|
hmmm @anitacaron I've added OMO and all but doesn't seem to want to import IAO_0000028 (symbol) still |
|
Does the import system work for APs? Has never been clear to me. |
that is a good question, don't think I've imported an AP before hmmm - if we cant import it, how do we use it? just with a label? |
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so. |
|
I'm updating this issue to try to merge it if it's still pertinent.
|
|
I can fix the many conflicts if this is still relevant. |
|
I think these are still useful, though honestly at this point, I think its easier to just reopen a new PR and use the diff here to add those symbols in. Happy to do it, but ODK is hard for me to access here, so would much prefer it if someone could create a branch with symbol being imported from IAO, and I can work from there. Thanks :) |
|
Would like symbol added ASAP. Anyone know if we can legally pun class -> AP? |
|
class-AP punning is allowed https://www.w3.org/TR/owl2-new-features/#F12:_Punning |
|
@shawntanzk, we can always update the PR, no need to create another one. I'll update this PR. |
Seems like we need a dedicated make goal that adds AP declaration for IAO classes (although I think OMO was meant to solve this) |
|
Can it be declared in the |
Is there a reason we need to declare it? I mean I dont think its a big deal, but my understanding was that if we declare it explicitly and for some reason done use it later, it will cause some issues or something? That being said, I remember us saying its not a big deal at all. Anyway just looked at it in protege, and looks alright at face value? |
|
@shawntanzk, we need to redefine it as an annotation property because it's officially a class. |
oh yeah, that totally makes sense :) Thanks @anitacaron, youre the best! |
|
#gogoeditdiff |
|
Ok really didnt have to gogoedit diff lol, looks good, merging in to make next release :) thanks all! |
drafting first, probably need a look through to standardise things a bit more