Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses #3088 change vascular object property #3106

Merged
merged 12 commits into from
Nov 30, 2023
Merged

Addresses #3088 change vascular object property #3106

merged 12 commits into from
Nov 30, 2023

Conversation

aleixpuigb
Copy link
Collaborator

Addresses #3088 change vascular object property

@aleixpuigb
Addresses #3088 change vascular object property
44fe863 
Addresses #3088 change vascular object property
@aleixpuigb aleixpuigb self-assigned this Nov 1, 2023
@aleixpuigb aleixpuigb linked an issue Nov 3, 2023 that may be closed by this pull request
switch branching_part_of use in the vasculature to connecting branch of #3088
Closed
@aleixpuigb aleixpuigb marked this pull request as draft November 6, 2023 14:35
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@aleixpuigb
Fix axioms
85c3526 
There were some arteries that were branches of two different arteries. I have fixed them and add the missing axioms in the DOSDP table.
@aleixpuigb aleixpuigb requested a review from a user November 9, 2023 09:05
@aleixpuigb aleixpuigb marked this pull request as ready for review November 9, 2023 09:06
@aleixpuigb aleixpuigb mentioned this pull request Nov 23, 2023
Merged
@aleixpuigb aleixpuigb removed the request for review from a user November 29, 2023 12:57
dosumis
dosumis approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Task is not to review accuracy of relationships but to switch existing ones - so I've just reviewed on that basis.

@aleixpuigb aleixpuigb merged commit 5c9edfb into master Nov 30, 2023
1 check passed
@aleixpuigb aleixpuigb deleted the 3088_update_connecting_branch_of branch November 30, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosumis dosumis dosumis approved these changes

@anitacaron anitacaron Awaiting requested review from anitacaron

@matentzn matentzn Awaiting requested review from matentzn matentzn is a code owner

Assignees

@aleixpuigb aleixpuigb

Labels
HuBMAP uberon-classhierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch branching_part_of use in the vasculature to connecting branch of
2 participants
@aleixpuigb @dosumis