MySQL2 to handle MongoDB connector BI #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2023 14:42
Sylvestre67
changed the title
visnup
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the
MySQLclient code currently in thedatabase-connectorat parity with the one in thedatabase-proxy.It removes
mysqlnpm library and replace it withmysql2in order to support theAUTH.send_clean_passwordauthentication plugin required by MongoDB connector for BI.It implements the
loggermiddleware defined in thedata-connectorservice.See corresponding
data-connectorPR: https://github.com/observablehq/observablehq/pull/10039 to get the global picture.