Add eslint import plugin and fix import ordering #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiltsecarpenter
force-pushed
the
wiltse/importlint
branch
from
a88c693 to
46dfd93
Compare
mbostock
reviewed
Nov 7, 2023
src/build.ts
Outdated
| import {parseArgs} from "node:util"; | ||
| import {findLoader, runLoader} from "./dataloader.js"; | ||
| import {maybeStat, prepareOutput, visitFiles, visitMarkdownFiles} from "./files.js"; | ||
| import {prepareOutput, visitFiles, visitMarkdownFiles, maybeStat} from "./files.js"; |
There was a problem hiding this comment.
I’m curious what’s happening here, since this doesn’t seem to be alphabetical order (of imported symbols)? I don’t really care whether the imported symbols are ordered… I just sort the files being imported.
There was a problem hiding this comment.
I think this was just the result of a manual merge. I don't think that there is a rule for ordering the imports, I'll check.
There was a problem hiding this comment.
I added a rule to enforce sorting of names within an import and added the changed files to the PR.
mbostock
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the eslint import plugin which does a bunch of checks on import statements, including enforcing ordering. It uses mostly just the recommended rules with a few local changes.