Skip to content

Escape ampersands in attribute values. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

Escape ampersands in attribute values. #12

merged 1 commit into from
Feb 20, 2020

Conversation

mbostock
Copy link
Member

Fixes #11.

@mbostock mbostock requested a review from jashkenas February 19, 2020 20:08
jashkenas
jashkenas approved these changes Feb 19, 2020
View reviewed changes
Copy link

@jashkenas jashkenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

👍

@mbostock mbostock merged commit 942c906 into master Feb 20, 2020
@mbostock mbostock deleted the escape-attribute branch February 20, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jashkenas jashkenas jashkenas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some entities need escaping within attributes.
2 participants
@mbostock @jashkenas