Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate domain sort in basic transforms #1315

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Mar 4, 2023

Fixes #1303. (This appears to be a separate issue from #840, though…)

@mbostock mbostock requested a review from Fil March 4, 2023 04:53
Fil added a commit that referenced this pull request Mar 6, 2023
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that it works well in conjunction with #1316.
Build: observablehq.com/@observablehq/plot-sort-1315-1316

@mbostock mbostock force-pushed the mbostock/fix-transform-channel-domain branch from 5519b31 to f32b77e Compare March 7, 2023 16:55
@mbostock mbostock merged commit 2f9e1d5 into main Mar 7, 2023
@mbostock mbostock deleted the mbostock/fix-transform-channel-domain branch March 7, 2023 16:56
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* propagate domain sort in basic transforms

* inline destructuring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort: {[scale]: channel} doesn’t work when combined with a transform
2 participants