color scale override for Plot.raster #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
requested changes
Mar 14, 2023
src/marks/raster.js
Outdated
| return super.scale(channels, scales, context); | ||
| } | ||
| render(index, scales, channels, dimensions, context) { | ||
| const color = scales.color ?? ((x) => x); | ||
| const color = this.recolor && scales.color ? scales.color : (x) => x; |
There was a problem hiding this comment.
I think you want something like this:
Suggested change
| const color = this.recolor && scales.color ? scales.color : (x) => x; | |
| const color = scales[this.channels.fill?.scale] ?? (x) => x; |
There was a problem hiding this comment.
hadn't thought about that, but it makes sense!
There was a problem hiding this comment.
this.channels.fill.scale comes in as "auto" and not "color", so I had to adapt a bit
Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Maybe it wasn’t clear, but I’m trying to avoid needing a side-effect in the raster.scale method. Why can’t we just figure out the appropriate color scale in raster.render instead?
Edit: You may need to call inferChannelScale to convert auto to something more specific.
mbostock
approved these changes
Mar 14, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* closes observablehq#1317 * Update src/marks/raster.js Co-authored-by: Mike Bostock <mbostock@gmail.com> * don't hardcode that fill is scaled with {color} * expose channel states to render --------- Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of f028a08 color scale overrides didn't work for Plot.raster
closes #1317