labelArrow option #1566
Merged
labelArrow option #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As context, there are several benefits of removing the arrows:
|
Fil
approved these changes
May 17, 2023
There was a problem hiding this comment.
This is great, thank you!
I'm adding a suggestion for docs in #1568, I also figured we might appreciate an example with an explicit labelArrow where true would not do the right thing? Like a depth transect of some sort, where you'd want depth to ↓ to the negatives. (But I can't find a handy dataset to play with…)
* document labelArrow * *up*, *right*, *down*, *left* * axis options edits * copy edits --------- Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
force-pushed
the
mbostock/label-arrow
branch
from
673e913 to
567f54c
Compare
Merged
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* labelArrow option * labelArrow docs (observablehq#1568) * document labelArrow * *up*, *right*, *down*, *left* * axis options edits * copy edits --------- Co-authored-by: Mike Bostock <mbostock@gmail.com> --------- Co-authored-by: Philippe Rivière <fil@rezo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #510. Supersedes #702.
Plot now applies a directional arrow such as → or ↑ automatically, even if the scale label is specified explicitly, as long as the given label does not already include a directional arrow. The arrow can be suppressed by setting the labelArrow option to none, null, or false. In addition, the arrow can be forced in cases where it would not appear automatically, such as for ordinal scales, by setting the labelArrow option to true or one of the four orientations: up, right, bottom, or left.
Previously in our repo there were 175 instances of Unicode arrows in specified labels; with this change, there are now only 14 instances! (−92%) The remaining instances are solely for double-ended arrows such as
← Women · Men →.