implicit categorical color scale #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a regression on the walmart raster tests, but I don't think it makes sense to force a diverging scheme onto a temporal scale (with a default pivot at unix epoch?). I'm suggesting a different priority order in #1569. |
Fil
approved these changes
May 17, 2023
* add missing test result * test the scheme after the domain and channels have been checked * scheme-less asOrdinalType --------- Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
force-pushed
the
mbostock/implicit-categorical
branch
from
e365e50 to
a2736b8
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* implicit categorical color scale * implicit categorical color scale (observablehq#1569) * add missing test result * test the scheme after the domain and channels have been checked * scheme-less asOrdinalType --------- Co-authored-by: Mike Bostock <mbostock@gmail.com> --------- Co-authored-by: Philippe Rivière <fil@rezo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1523.