Skip to content

test:tsc in CI #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
branches: [main]

jobs:
build:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -16,11 +16,12 @@ jobs:
node-version: 16
cache: 'yarn'
- run: yarn --frozen-lockfile
- run: yarn test:mocha
- run: yarn test:tsc
- run: |
echo ::add-matcher::.github/eslint.json
yarn run eslint src test --format=compact
- run: yarn run prettier --check src test
- run: yarn test:mocha
- run: yarn test:prettier
- run: yarn prepublishOnly
- run: yarn docs:build
- uses: actions/upload-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion src/transforms/bin.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export type BinYInputs<T> = Omit<T, "y"> & {y?: ChannelValueBinSpec} & BinOption
export type BinInputs<T> = Omit<T, "x" | "y"> & {x?: ChannelValueBinSpec; y?: ChannelValueBinSpec} & BinOptions;

/** Output channels (and options) for the bin transform. */
export type BinOutputs = ChannelReducers<BinReducer> & GroupOutputOptions<BinReducer> & BinOptions;
export type BinOutputs = ChannelReducers<BinReducer> | (GroupOutputOptions<BinReducer> & BinOptions);

/**
* Bins on the **x** channel; then subdivides bins on the first channel of
Expand Down
2 changes: 1 addition & 1 deletion src/transforms/group.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface GroupOutputOptions<T = Reducer> {
}

/** Output channels (and options) for the group transform. */
export type GroupOutputs = ChannelReducers & GroupOutputOptions;
export type GroupOutputs = ChannelReducers | GroupOutputOptions;

/**
* Groups on the first channel of **z**, **fill**, or **stroke**, if any, and
Expand Down