Skip to content

Image mark #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Dec 1, 2021
Merged

Image mark #599

merged 20 commits into from
Dec 1, 2021

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Nov 29, 2021

Supersedes #459. Fixes #157.

TODO

  • width and height instead of r
  • width defaults to height and vice versa
  • src instead of href
  • ignore fill and stroke attributes
  • opacity attribute
  • allow src to be a constant
  • documentation

@mbostock mbostock mentioned this pull request Nov 29, 2021
7 tasks
@RLesser
Copy link
Contributor

RLesser commented Nov 29, 2021

Thanks for incorporating this Mike!

@mbostock mbostock requested a review from Fil November 29, 2021 21:33
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we allow for clipping—for example, for the very common task of making rounded avatars?

@mbostock
Copy link
Member Author

mbostock commented Nov 30, 2021

How would we allow for clipping—for example, for the very common task of making rounded avatars?

My thinking is we could reintroduce the r channel for this. Or we could introduce another mark type. Or we could add an image channel for the dot mark. Or we could have some generic clipping mechanism that could apply to all mark types?

@mbostock mbostock merged commit badc7ec into main Dec 1, 2021
@mbostock mbostock deleted the mbostock/image branch December 1, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image mark?
3 participants