Skip to content

fix ramp legend font-variant #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jun 2, 2022

The label for a ramp legend was erroneously inheriting the tabular-nums font-variant needed for axis ticks. This fixes it by making it a sibling rather than a child of the axis. I guess there’s the same bug with axis labels (which very rarely include numbers, so we didn’t notice).

Before
Screen Shot 2022-06-02 at 11 50 35 AM

After
Screen Shot 2022-06-02 at 11 50 05 AM

@mbostock mbostock requested a review from Fil June 2, 2022 18:50
@mbostock mbostock merged commit f00e7cc into main Jun 2, 2022
@mbostock mbostock deleted the mbostock/fix-legend-label-font-variant branch June 2, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants