Remove existing fragment identifier in DOM.uid #114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concatenating `#` + id to `window.location` results in UID hrefs with _two_ fragment identifiers. This commit removes the existing fragment identifier before concatenating.
rreusser
changed the title
rreusser
changed the title
mbostock
reviewed
Sep 3, 2019
rreusser
commented
Sep 3, 2019
|
Good suggestion, @mbostock. I've updated the PR with that version. |
|
Merged into #128 for 3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appending
"#" + idtowindow.locationresults in UID hrefs with two fragment identifiers. This commit removes the existing fragment identifier before appending the new one.For an example of the currently-broken behavior, see https://observablehq.com/@mbostock/svg-clipping-test#foo. The preexisting fragment identifier
#fooreturns it to broken clipping.