Export __table function #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
requested changes
Nov 16, 2022
There was a problem hiding this comment.
I think we shouldn’t export this under the name __table; that (internal) name was chosen for parity with __query, and the name __query was chosen because it needs to be exposed to notebooks (so that we can call it from the compiled representation of a SQL or data table cell).
But that’s not the case with __table. It’s never called directly from notebooks, so we don’t need to give it a dunderscore name.
Maybe a big clunky name like applyDataTableOperations?
|
Love a big clunky name (and thanks for the background context on the name) |
mbostock
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports the
__tablefunction for use in the Observable Data Table and SQL cells.